LayoutTests/fast/css/css-escaped-identifier.html - Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css/css-escaped-identifier.html

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Ensure getComputedStyle returns absolute URLs Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css/all-inherit-or-unset-color.html ('K') | « LayoutTests/fast/css/all-inherit-or-unset-color-expected.html ('k') | LayoutTests/fast/css/css-imagevalue-url.html » ('j') | LayoutTests/fast/css/getComputedStyle-relativeURL-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css/css-escaped-identifier.html

diff --git a/LayoutTests/fast/css/css-escaped-identifier.html b/LayoutTests/fast/css/css-escaped-identifier.html

index c2e1190945e08188ca7aab73cc274f72b61f3a33..e73841352441bc264df37ea08e9901a519650fe5 100644

--- a/LayoutTests/fast/css/css-escaped-identifier.html

+++ b/LayoutTests/fast/css/css-escaped-identifier.html

@@ -21,8 +21,8 @@

assert_equals(rules.length, 4, "cssRules.length == 4");

assert_equals(rules[0].selectorText, "d\ueeeex", "Lowercase identifier with escapes");

assert_equals(rules[1].selectorText, "d\ueeeex", "Uppercase identifier with escapes");

- assert_equals(rules[2].style.cssText, "background-image: url(http://w/%EA%AA%AA/1b%EA%AA%AA.gif);", "Escaped url string");

- assert_equals(rules[3].style.cssText, "background-image: url(http://w/%EA%AA%AA/1b%EA%AA%AA.gif);", "Escaped url without string");

+ assert_equals(rules[2].style.cssText, "background-image: url(http://w/" + decodeURIComponent("%EA%AA%AA") + "/1b" + decodeURIComponent("%EA%AA%AA") + ".gif);", "Escaped url string");

Timothy Loh 2015/09/15 12:20:47 The patch description should probably mention this

nainar 2015/09/16 07:16:48 The resulting output is consistent with FF. Changi

+ assert_equals(rules[3].style.cssText, "background-image: url(http://w/" + decodeURIComponent("%EA%AA%AA") + "/1b" + decodeURIComponent("%EA%AA%AA") + ".gif);", "Escaped url without string");

}, "Correctly parsed identifier with escapes");

</script>

</head>