LayoutTests/fast/css/getComputedStyle-relativeURL.html - Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/getComputedStyle-relativeURL.html

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: As per feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css/css-imagevalue-url.html ('K') | « LayoutTests/fast/css/css-imagevalue-url.html ('k') | LayoutTests/fast/css/parse-border-image-repeat-null-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4

	5 <div id = "target1"></div>
	alancutter (OOO until 2018) 2015/09/21 00:57:47 s/target1/target/ Spaces around the = is inconsist s/target1/target/ Spaces around the = is inconsistent with other DOM nodes and general LayoutTest style. nainar 2015/09/21 01:27:36 Done. Done.
	6

	7 <script>

	8 target1.style.backgroundImage = "-webkit-cross-fade(url(images1.jpg), url(imag es2.jpg), 0.5)";

	9 test(function() {

	10 assert_not_equals(target1.style.backgroundImage, getComputedStyle(target1).b ackgroundImage);
	alancutter (OOO until 2018) 2015/09/21 00:57:47 This is a fairly weak assertion. You can build the This is a fairly weak assertion. You can build the expected string using location.href.replace('getComputedStyle-relativeURL.html', 'images1.jpg'). nainar 2015/09/21 01:27:36 Done. Done.
	11 assert_equals(target1.style.backgroundImage, "-webkit-cross-fade(url(images1 .jpg), url(images2.jpg), 0.5)");

	12 }, 'Testing that getComputedStyle.backgroundImage returns absolute URLs and st yle.backgroundImage returns relative URLs');

	13 </script>

OLD	NEW