LayoutTests/fast/css/css-imagevalue-url.html - Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/css-imagevalue-url.html

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/css-escaped-identifier.html ('k') | LayoutTests/fast/css/getComputedStyle-relativeURL.html » ('j') | LayoutTests/fast/css/getComputedStyle-relativeURL.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4

	5 <style>

	6 div { background-image: url(images.jpg); }

	7 </style>

	8

	9 <body>

	10 </body>

	11

	12 <script>

	13 var rulesForCssText = function (styleContent) {
	alancutter (OOO until 2018) 2015/09/18 02:55:09 No space after function. No space after function. nainar 2015/09/18 03:47:24 Done. Done.
	14 var doc = document.implementation.createHTMLDocument(""),

	15 styleElement = document.createElement("style");
	alancutter (OOO until 2018) 2015/09/18 02:55:09 Use separate var statements. Use separate var statements. nainar 2015/09/18 03:47:25 Done. Done.
	16

	17 styleElement.textContent = styleContent;

	18 // the style will only parsed once it is added to a document
	alancutter (OOO until 2018) 2015/09/18 02:55:09 No need for comment. No need for comment. nainar 2015/09/18 03:47:24 Done. Done.
	19 doc.body.appendChild(styleElement);

	20

	21 return styleElement.sheet.cssRules;

	22 };

	23

	24 var cssRulesToText = function (cssRules) {

	25 var cssText = "";

	26 Array.prototype.slice.call(cssRules).forEach(function (rule) {

	27 cssText += rule.cssText;

	28 });

	29 return cssText;

	30 };

	31

	32 addEventListener("load", function() {

	33 test(function() {

	34 var styles = document.getElementsByTagName("style"),

	35 cssText = styles[styles.length-1].textContent.trim();

	36 assert_equals(cssRulesToText(rulesForCssText(cssText)), cssText);
	alancutter (OOO until 2018) 2015/09/18 02:55:09 No need for the helper functions if they're only d No need for the helper functions if they're only doing one item. No need for the <style> element on this page when you intend to simply set text from Javascript. nainar 2015/09/18 03:47:24 Done. Done. Done. Done.
	37 }, 'Testing URLs in CSS');
	alancutter (OOO until 2018) 2015/09/18 02:55:09 This is very vague, you're actually testing serial This is very vague, you're actually testing serialisation and round tripping of urls in CSS. nainar 2015/09/18 03:47:24 Done. Done.
	38 }, false);

	39 </script>

OLD	NEW