Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: Source/core/style/StyleFetchedImageSet.cpp

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Ensure getComputedStyle returns absolute URLs Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 StyleFetchedImageSet::~StyleFetchedImageSet() 45 StyleFetchedImageSet::~StyleFetchedImageSet()
46 { 46 {
47 m_bestFitImage->removeClient(this); 47 m_bestFitImage->removeClient(this);
48 } 48 }
49 49
50 PassRefPtrWillBeRawPtr<CSSValue> StyleFetchedImageSet::cssValue() const 50 PassRefPtrWillBeRawPtr<CSSValue> StyleFetchedImageSet::cssValue() const
51 { 51 {
52 return m_imageSetValue; 52 return m_imageSetValue;
53 } 53 }
54 54
55 PassRefPtrWillBeRawPtr<CSSValue> StyleFetchedImageSet::computedCSSValue() const
56 {
57 return m_imageSetValue ? m_imageSetValue->valueWithAbsoluteURL() : nullptr;
Timothy Loh 2015/09/15 12:20:47 Looks like m_imageSetValue is never null?
nainar 2015/09/16 07:16:49 Done.
58 }
59
55 bool StyleFetchedImageSet::canRender(const LayoutObject& layoutObject, float mul tiplier) const 60 bool StyleFetchedImageSet::canRender(const LayoutObject& layoutObject, float mul tiplier) const
56 { 61 {
57 return m_bestFitImage->canRender(layoutObject, multiplier); 62 return m_bestFitImage->canRender(layoutObject, multiplier);
58 } 63 }
59 64
60 bool StyleFetchedImageSet::isLoaded() const 65 bool StyleFetchedImageSet::isLoaded() const
61 { 66 {
62 return m_bestFitImage->isLoaded(); 67 return m_bestFitImage->isLoaded();
63 } 68 }
64 69
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 return m_bestFitImage->currentFrameKnownToBeOpaque(layoutObject); 124 return m_bestFitImage->currentFrameKnownToBeOpaque(layoutObject);
120 } 125 }
121 126
122 DEFINE_TRACE(StyleFetchedImageSet) 127 DEFINE_TRACE(StyleFetchedImageSet)
123 { 128 {
124 visitor->trace(m_imageSetValue); 129 visitor->trace(m_imageSetValue);
125 StyleImage::trace(visitor); 130 StyleImage::trace(visitor);
126 } 131 }
127 132
128 } // namespace blink 133 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698