Source/core/css/CSSMarkup.h - Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/css/CSSMarkup.h

Issue 1306283006: BackgroundImage incorrectly returns empty url() when created on-the-fly (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Ensure getComputedStyle returns absolute URLs Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/css/CSSImageValue.cpp ('K') | « Source/core/css/CSSImageValue.cpp ('k') | Source/core/css/CSSMarkup.cpp » ('j') | Source/core/css/CSSMarkup.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)

3 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserv ed.	3 * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserv ed.

4 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>	4 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>

5 * Copyright (C) 2009 - 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserve d.	5 * Copyright (C) 2009 - 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserve d.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 18 matching lines...) Expand all Loading...
29	29

30 namespace blink {	30 namespace blink {

31	31

32 String quoteCSSStringIfNeeded(const String&);	32 String quoteCSSStringIfNeeded(const String&);

33 String quoteCSSURLIfNeeded(const String&);	33 String quoteCSSURLIfNeeded(const String&);

34	34

35 // Common serializing methods. See: http://dev.w3.org/csswg/cssom/#common-serial izing-idioms	35 // Common serializing methods. See: http://dev.w3.org/csswg/cssom/#common-serial izing-idioms

36 bool serializeIdentifier(const String& identifier, StringBuilder& appendTo);	36 bool serializeIdentifier(const String& identifier, StringBuilder& appendTo);

37 void serializeString(const String&, StringBuilder& appendTo);	37 void serializeString(const String&, StringBuilder& appendTo);

38 String serializeString(const String&);	38 String serializeString(const String&);

39	39 String serializeStringWithoutQuotations(const String&);
	Timothy Loh 2015/09/15 12:20:47 This function isn't a common serializing method fr This function isn't a common serializing method from the specs like the comment above suggests. nainar 2015/09/16 07:16:49 Currently, we don't serialize strings the way the Currently, we don't serialize strings the way the spec asks (https://drafts.csswg.org/cssom/#serialize-a-string). FF does. This function is to ensure we are on par with other Chrome layout test which doesn't enclose relative URL in quotes. A later patch will remove this function and instead call serializeString along with making sure that all tests too are updated.
40	40

41 } // namespace blink	41 } // namespace blink

42	42

43 #endif // CSSMarkup_h	43 #endif // CSSMarkup_h

OLD	NEW