BackgroundImage incorrectly returns empty url() when created on-the-fly

Source/core/css/CSSCrossfadeValue.h

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 24 matching lines @@
 
 namespace blink {
 
 class ImageResource;
 class CrossfadeSubimageObserverProxy;
 class LayoutObject;
 
 class CSSCrossfadeValue final : public CSSImageGeneratorValue {
     friend class CrossfadeSubimageObserverProxy;
 public:
-    static PassRefPtrWillBeRawPtr<CSSCrossfadeValue> create(PassRefPtrWillBeRawPtr<CSSValue> fromValue, PassRefPtrWillBeRawPtr<CSSValue> toValue)
+    static PassRefPtrWillBeRawPtr<CSSCrossfadeValue> create(PassRefPtrWillBeRawPtr<CSSValue> fromValue, PassRefPtrWillBeRawPtr<CSSValue> toValue, PassRefPtrWillBeRawPtr<CSSPrimitiveValue> percentageValue = nullptr)

[Timothy Loh, 2015/09/15 12:20:47]

Better to do this change separately and properly (i.e. without the default
argument)

[nainar, 2015/09/16 07:16:49]

Done. 

     {
-        return adoptRefWillBeNoop(new CSSCrossfadeValue(fromValue, toValue));
+        return adoptRefWillBeNoop(new CSSCrossfadeValue(fromValue, toValue, percentageValue));
     }
 
     ~CSSCrossfadeValue();
 
     String customCSSText() const;
 
     PassRefPtr<Image> image(LayoutObject*, const IntSize&);
     bool isFixedSize() const { return true; }
     IntSize fixedSize(const LayoutObject*);
 
     bool isPending() const;
     bool knownToBeOpaque(const LayoutObject*) const;
 
     void loadSubimages(Document*);
 
     void setPercentage(PassRefPtrWillBeRawPtr<CSSPrimitiveValue> percentageValue) { m_percentageValue = percentageValue; }
 
     bool hasFailedOrCanceledSubresources() const;
 
     bool equals(const CSSCrossfadeValue&) const;
 
+    PassRefPtrWillBeRawPtr<CSSCrossfadeValue> valueWithAbsoluteURL();
+
     // Promptly remove as a ImageResource client.
     EAGERLY_FINALIZE();
 #if ENABLE(OILPAN)
     DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();
 #endif
     DECLARE_TRACE_AFTER_DISPATCH();
 
 private:
-    CSSCrossfadeValue(PassRefPtrWillBeRawPtr<CSSValue> fromValue, PassRefPtrWillBeRawPtr<CSSValue> toValue)
+    CSSCrossfadeValue(PassRefPtrWillBeRawPtr<CSSValue> fromValue, PassRefPtrWillBeRawPtr<CSSValue> toValue, PassRefPtrWillBeRawPtr<CSSPrimitiveValue> percentageValue)
         : CSSImageGeneratorValue(CrossfadeClass)
         , m_fromValue(fromValue)
         , m_toValue(toValue)
-        , m_cachedFromImage(nullptr)
-        , m_cachedToImage(nullptr)
+        , m_percentageValue(percentageValue)
+        , m_cachedFromImage(0)

[Timothy Loh, 2015/09/15 12:20:47]

Why the change?

[nainar, 2015/09/16 07:16:49]

Fixed.

+        , m_cachedToImage(0)
         , m_crossfadeSubimageObserver(this) { }
 
     class CrossfadeSubimageObserverProxy final : public ImageResourceClient {
         DISALLOW_ALLOCATION();
     public:
         explicit CrossfadeSubimageObserverProxy(CSSCrossfadeValue* ownerValue)
             : m_ownerValue(ownerValue)
             , m_ready(false) { }
 
         ~CrossfadeSubimageObserverProxy() override { }
@@ skipping 21 matching lines @@
     RefPtr<Image> m_generatedImage;
 
     CrossfadeSubimageObserverProxy m_crossfadeSubimageObserver;
 };
 
 DEFINE_CSS_VALUE_TYPE_CASTS(CSSCrossfadeValue, isCrossfadeValue());
 
 } // namespace blink
 
 #endif // CSSCrossfadeValue_h