BackgroundImage incorrectly returns empty url() when created on-the-fly

Source/core/css/CSSCrossfadeValue.cpp

 /*
  * Copyright (C) 2011 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 99 matching lines @@
     result.appendLiteral("-webkit-cross-fade(");
     result.append(m_fromValue->cssText());
     result.appendLiteral(", ");
     result.append(m_toValue->cssText());
     result.appendLiteral(", ");
     result.append(m_percentageValue->cssText());
     result.append(')');
     return result.toString();
 }
 
+PassRefPtrWillBeRawPtr<CSSCrossfadeValue> CSSCrossfadeValue::valueWithAbsoluteURL()
+{
+    if (m_fromValue->isImageValue() && m_toValue->isImageValue()) {

[Timothy Loh, 2015/09/15 12:20:47]

The logic here seems weird. What if only one side is an image value?

[nainar, 2015/09/16 07:16:48]

Fixed.

+        return CSSCrossfadeValue::create(toCSSImageValue(*m_fromValue).valueWithAbsoluteURL(), toCSSImageValue(*m_toValue).valueWithAbsoluteURL(), m_percentageValue);
+    }
+    return this;
+}
+
 IntSize CSSCrossfadeValue::fixedSize(const LayoutObject* layoutObject)
 {
-    Image* fromImage = renderableImageForCSSValue(m_fromValue.get(), layoutObject);
-    Image* toImage = renderableImageForCSSValue(m_toValue.get(), layoutObject);
+    float percentage = m_percentageValue->getFloatValue();

[Timothy Loh, 2015/09/15 12:20:47]

???

[nainar, 2015/09/16 07:16:48]

Fixed.

+    float inversePercentage = 1 - percentage;
+
+    Document* document = &layoutObject->document();
+    ImageResource* cachedFromImage = cachedImageForCSSValue(m_fromValue.get(), document);
+    ImageResource* cachedToImage = cachedImageForCSSValue(m_toValue.get(), document);
 
     if (!fromImage || !toImage)
         return IntSize();
 
     IntSize fromImageSize = fromImage->size();
     IntSize toImageSize = toImage->size();
 
     // Rounding issues can cause transitions between images of equal size to return
     // a different fixed size; avoid performing the interpolation if the images are the same size.
     if (fromImageSize == toImageSize)
@@ skipping 90 matching lines @@
 DEFINE_TRACE_AFTER_DISPATCH(CSSCrossfadeValue)
 {
     visitor->trace(m_fromValue);
     visitor->trace(m_toValue);
     visitor->trace(m_percentageValue);
     visitor->trace(m_crossfadeSubimageObserver);
     CSSImageGeneratorValue::traceAfterDispatch(visitor);
 }
 
 } // namespace blink