Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Issue 1306243006: Replace forward class declarations of VisiblePosition to include directives (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace forward class declarations of VisiblePosition to include directive This patch replaces forward class declarations |VisiblePosition| to include directive of "VisiblePosition.h" as preparation of introducing |VisiblePositionTemplate<Strategy>|, like |PositionAlgorithm<Strategy>|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M Source/core/editing/EditingUtilities.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/RenderedPosition.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/commands/FormatBlockCommand.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-24 05:09:16 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-24 05:45:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306243006/1
5 years, 4 months ago (2015-08-24 05:48:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102933)
5 years, 4 months ago (2015-08-24 07:14:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306243006/1
5 years, 4 months ago (2015-08-24 07:43:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102969)
5 years, 4 months ago (2015-08-24 09:09:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306243006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306243006/1
5 years, 4 months ago (2015-08-24 09:14:04 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 10:03:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201056

Powered by Google App Engine
This is Rietveld 408576698