Issue 1306233003: Markdown style fixes for:

Issue 1306233003: Markdown style fixes for: (Closed)

Created:
5 years, 4 months ago by Bons

Modified:
5 years, 3 months ago

Reviewers:
nodir

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Markdown style fixes for: code_coverage.md cocoa_tips_and_tricks.md closure_compilation.md clang_format.md clang_tool_refactoring.md clang.md R=nodir BUG=524256 Committed: https://crrev.com/6eaa0c0d0154e824a99267abb24bd536b7bacae1 Cr-Commit-Position: refs/heads/master@{#345652}

Patch Set 1 #

Total comments: 17

Patch Set 2 : style changes #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -155 lines)			Patch
M	docs/clang.md	View	1	1 chunk	+67 lines, -39 lines	0 comments	Download
M	docs/clang_format.md	View	1	1 chunk	+52 lines, -19 lines	0 comments	Download
M	docs/clang_tool_refactoring.md	View		1 chunk	+79 lines, -31 lines	0 comments	Download
M	docs/closure_compilation.md	View	1	8 chunks	+67 lines, -38 lines	0 comments	Download
M	docs/cocoa_tips_and_tricks.md	View		3 chunks	+28 lines, -12 lines	0 comments	Download
M	docs/code_coverage.md	View		1 chunk	+29 lines, -16 lines	0 comments	Download

Messages

Total messages: 9 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nodir

https://codereview.chromium.org/1306233003/diff/1/docs/clang.md File docs/clang.md (right): https://codereview.chromium.org/1306233003/diff/1/docs/clang.md#newcode21 docs/clang.md:21: ``` nit: 4 space indent is best for oneliners ...

5 years, 3 months ago (2015-08-26 16:26:17 UTC) #3

Bons

5 years, 3 months ago (2015-08-26 19:43:15 UTC) #4

https://codereview.chromium.org/1306233003/diff/1/docs/clang.md
File docs/clang.md (right):

https://codereview.chromium.org/1306233003/diff/1/docs/clang.md#newcode21
docs/clang.md:21: ```
On 2015/08/26 16:26:17, nodir wrote:
> nit: 4 space indent is best for oneliners

Done.

https://codereview.chromium.org/1306233003/diff/1/docs/clang.md#newcode76
docs/clang.md:76: See [clang_static_analyser.md].
On 2015/08/26 16:26:17, nodir wrote:
> This won't become a link on itself (unfortunately)

Done.

https://codereview.chromium.org/1306233003/diff/1/docs/clang.md#newcode90
docs/clang.md:90: python tools\clang\scripts\update.py set GYP_DEFINES=clang=1 \
On 2015/08/26 16:26:17, nodir wrote:
> Not sure this is correct:
> is "set" a command of update.py? (I am not familiar with clang)
> 
> Why "\" in the end? Next line is python script, it seems

Done.

https://codereview.chromium.org/1306233003/diff/1/docs/clang.md#newcode119
docs/clang.md:119: build/gyp_chromium
On 2015/08/26 16:26:17, nodir wrote:
> Consider indenting lines 118,119, so it is obvious that they are part of line
> 117

within the g3 style guide it doesn't show its example with an indentation

https://codereview.chromium.org/1306233003/diff/1/docs/clang_format.md
File docs/clang_format.md (right):

https://codereview.chromium.org/1306233003/diff/1/docs/clang_format.md#newcode61
docs/clang_format.md:61: [Chromium bug using this
link](https://code.google.com/p/chromium/issues/entry?comment=clang-format%20produced%20code%20that%20(choose%20all%20that%20apply):%20%0A-%20Doesn%27t%20match%20Chromium%20style%0A-%20Doesn%27t%20match%20blink%20style%0A-%20Riles%20my%20finely%20honed%20stylistic%20dander%0A-%20No%20sane%20human%20would%20ever%20choose%0A%0AHere%27s%20the%20code%20before%20formatting:%0A%0A%0AHere%27s%20the%20code%20after%20formatting:%0A%0A%0AHere%27s%20how%20it%20ought%20to%20look:%0A%0A%0ACode%20review%20link%20for%20full%20files/context:&summary=clang-format%20quality%20problem&cc=thakis@chromium.org,%20nick@chromium.org&labels=Type-Bug,Build-Tools,OS-?).
On 2015/08/26 16:26:17, nodir wrote:
> nit: for long bug links, I usually move the to the footer. Just "a [bug]."
here
> and
> 
> [bug]:
>
https://code.google.com/p/chromium/issues/entry?comment=clang-format%20produc...
>    
>
that%20(choose%20all%20that%20apply):%20%0A-%20Doesn%27t%20match%20Chromium%20style%0A-%20Doesn%27t%20match%20blink%20st
>    
>
yle%0A-%20Riles%20my%20finely%20honed%20stylistic%20dander%0A-%20No%20sane%20human%20would%20ever%20choose%0A%0AHere%27s
>    
>
%20the%20code%20before%20formatting:%0A%0A%0AHere%27s%20the%20code%20after%20formatting:%0A%0A%0AHere%27s%20how%20it%20o
>    
>
ught%20to%20look:%0A%0A%0ACode%20review%20link%20for%20full%20files/context:&summary=clang-format%20quality%20problem&cc
>    
mailto:=thakis@chromium.org,%20nick@chromium.org&labels=Type-Bug,Build-Tools,OS-?
> 
> in the end of the document.
> 
> No need to specify "using this link", see "Use informative Markdown link
titles"
> in the styleguide

Done.

https://codereview.chromium.org/1306233003/diff/1/docs/closure_compilation.md
File docs/closure_compilation.md (right):

https://codereview.chromium.org/1306233003/diff/1/docs/closure_compilation.md...
docs/closure_compilation.md:65: my_project/compiled_resources.gyp
On 2015/08/26 16:26:17, nodir wrote:
> remove ```, indent with 4 spaces

Done.

https://codereview.chromium.org/1306233003/diff/1/docs/closure_compilation.md...
docs/closure_compilation.md:111:
[third\_party/closure\_compiler/compiled\_resources.gyp](https://code.google.com/p/chromium/codesearch#chromium/src/third_party/closure_compiler/compiled_resources.gyp&sq=package:chromium&type=cs)
On 2015/08/26 16:26:17, nodir wrote:
> replace \_ with _
> MD is smart enough not to make bar in foo_bar_qux italic

Done.

https://codereview.chromium.org/1306233003/diff/1/docs/closure_compilation.md...
docs/closure_compilation.md:141: ```
On 2015/08/26 16:26:17, nodir wrote:
> 4 line indent

Done.

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306233003/20001

5 years, 3 months ago (2015-08-26 20:03:04 UTC) #7

commit-bot: I haz the power

5 years, 3 months ago (2015-08-26 20:14:05 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/6eaa0c0d0154e824a99267abb24bd536b7bacae1
Cr-Commit-Position: refs/heads/master@{#345652}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages