Issue 130623002: Clean up static_cast<SVGFooElement*> by using toSVGFoo()

Issue 130623002: Clean up static_cast<SVGFooElement*> by using toSVGFoo() (Closed)

Created:
6 years, 11 months ago by gyuyoung-inactive

Modified:
6 years, 11 months ago

Reviewers:
tkent, Hajime Morrita

CC:
blink-reviews, Steve Block, krit, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), Timothy Loh, dstockwell, dglazkov+blink, shans, f(malita), darktears, pdr, apavlov+blink_chromium.org, Stephen Chennney, Eric Willigers, dino_apple.com, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Clean up static_cast<SVGFooElement*> by using toSVGFoo() As a step to use toFoo(), this cl clean up static_cast<SVGAltGlyphDef|AltGlyph| AltGlyphItem|AnimateTransform|CursorElement*> by using toSVGFooElement(). To do it, This cl generate toSVGFooElement for below SVG elements. - SVGAltGlyphDefElement - SVGAltGlyphElement - SVGAltGlyphItemElement - SVGAnimateTransformElement - SVGCursorElement BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164838

Patch Set 1 #

Patch Set 2 : Rebased #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -7 lines)			Patch
M	Source/core/css/CSSCursorImageValue.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGAltGlyphDefElement.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGAltGlyphDefElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGAltGlyphElement.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGAltGlyphElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGAltGlyphItemElement.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGAltGlyphItemElement.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGAnimateTransformElement.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGAnimatedTransformList.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/SVGCursorElement.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGFontData.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/130623002/1

6 years, 11 months ago (2014-01-09 05:34:48 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=22112

6 years, 11 months ago (2014-01-09 08:57:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/130623002/160001

6 years, 11 months ago (2014-01-10 02:31:49 UTC) #5

Message was sent while issue was closed.

Change committed as 164838

Expand Messages | Collapse Messages