Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1306213002: Revert of Concurrently unmap free pages. (Closed)

Created:
5 years, 4 months ago by vogelheim
Modified:
5 years, 4 months ago
CC:
v8-dev, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Concurrently unmap free pages. (patchset #4 id:60001 of https://codereview.chromium.org/1303263002/ ) Reason for revert: Several tests on V8 Linux64 TSAN bot are broken, due to data races between allocation & GC. A bisect points to this CL, and the CL description sounds pertinent to the observed breakage. Original issue's description: > Concurrently unmap free pages. > > BUG= > > Committed: https://crrev.com/d1aeb45d96123d47023066b244c0f450fbe57d2d > Cr-Commit-Position: refs/heads/master@{#30306} TBR=mlippautz@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/218948e5f2b62ade15d4f6b969392989b3e66dba Cr-Commit-Position: refs/heads/master@{#30310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -55 lines) Patch
M src/heap/heap.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +4 lines, -45 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vogelheim
Created Revert of Concurrently unmap free pages.
5 years, 4 months ago (2015-08-21 16:20:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306213002/1
5 years, 4 months ago (2015-08-21 16:20:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 16:20:59 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 16:21:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/218948e5f2b62ade15d4f6b969392989b3e66dba
Cr-Commit-Position: refs/heads/master@{#30310}

Powered by Google App Engine
This is Rietveld 408576698