Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3254)

Unified Diff: chrome/browser/sync/test/integration/sync_test.h

Issue 1306163003: Dynamically create Gaia accounts when running E2E sync integration tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_test.h
diff --git a/chrome/browser/sync/test/integration/sync_test.h b/chrome/browser/sync/test/integration/sync_test.h
index dc9678d84fcb863fe1bfbe78da0c0a2fab3d3360..16039edcdf70fe03e4b03d4eec5e95c0d274e12c 100644
--- a/chrome/browser/sync/test/integration/sync_test.h
+++ b/chrome/browser/sync/test/integration/sync_test.h
@@ -285,6 +285,13 @@ class SyncTest : public InProcessBrowserTest {
// a profile then registers it as a testing profile.
Profile* MakeProfile(const base::FilePath::StringType name);
+ // Helper method used to create a Gaia account at runtime.
+ // This function should only be called when running against external servers
+ // which use local authentication servers.
pval...(no longer on Chromium) 2015/09/04 16:48:32 "external servers which use local authentication s
shadi 2015/09/04 21:43:45 Done.
+ // Returns true if account creation was successful, false otherwise.
+ bool CreateGaiaAccount(const std::string& username,
+ const std::string& password);
+
// Helper method used to read GAIA credentials from a local password file
// specified via the "--password-file-for-test" command line switch.
// Note: The password file must be a plain text file with exactly two lines --
@@ -397,6 +404,11 @@ class SyncTest : public InProcessBrowserTest {
// Defaults to true.
bool notifications_enabled_;
+ // Indicates the need to create Gaia user account at runtime. This can only be
+ // set if tests are run against external servers with support for user
+ // creation via http requests.
+ bool create_gaia_account_at_runtime_;
+
// Sync integration tests need to make live DNS requests for access to
// GAIA and sync server URLs under google.com. We use a scoped version
// to override the default resolver while the test is active.
« no previous file with comments | « no previous file | chrome/browser/sync/test/integration/sync_test.cc » ('j') | chrome/browser/sync/test/integration/sync_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698