Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 1306163002: Added TestCreate for GrComposeEffect (Closed)

Created:
5 years, 4 months ago by wangyix
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@cs3_composeshader2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Added TestCreate for SkComposeShader; will pick two random child procs that don't have children of their own. This prevents creating an arbitrarily large tree of procs. Also, it will choose a random coefficient mode for the xfermode. BUG=skia:4182 Committed: https://skia.googlesource.com/skia/+/036fd8e6f66b53cf87a5f91083cae82f0aeb3635

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : added #include for build errors #

Patch Set 5 : added #if STATIC_GLOBAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M src/core/SkComposeShader.cpp View 1 2 3 4 3 chunks +32 lines, -1 line 0 comments Download
M src/gpu/GrProcessor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 22 (10 generated)
wangyix
5 years, 4 months ago (2015-08-21 14:17:02 UTC) #2
joshualitt
On 2015/08/21 14:17:02, wangyix wrote: lgtm
5 years, 4 months ago (2015-08-21 14:17:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306163002/40001
5 years, 3 months ago (2015-09-08 15:42:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/2366)
5 years, 3 months ago (2015-09-08 15:43:38 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306163002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306163002/60001
5 years, 3 months ago (2015-09-08 15:50:26 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/1422) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
5 years, 3 months ago (2015-09-08 15:51:27 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306163002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306163002/80001
5 years, 3 months ago (2015-09-08 20:43:43 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 20:48:25 UTC) #16
wangyix
Brian, can you take a quick look at the latest patchset? I just added #if ...
5 years, 3 months ago (2015-09-08 20:56:12 UTC) #17
bsalomon
On 2015/09/08 20:56:12, wangyix wrote: > Brian, can you take a quick look at the ...
5 years, 3 months ago (2015-09-08 22:21:48 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306163002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306163002/80001
5 years, 3 months ago (2015-09-08 22:23:00 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 22:23:37 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/036fd8e6f66b53cf87a5f91083cae82f0aeb3635

Powered by Google App Engine
This is Rietveld 408576698