Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: components/suggestions/BUILD.gn

Issue 1306153002: Revert of Sync more GN unit tests with GYP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tests3
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sessions/BUILD.gn ('k') | components/sync_driver/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/suggestions/BUILD.gn
diff --git a/components/suggestions/BUILD.gn b/components/suggestions/BUILD.gn
index 389a19bb10e87caf4a49e153245a48087f95b843..58291765f4860dc76e827c1c4fc11738f6b6787b 100644
--- a/components/suggestions/BUILD.gn
+++ b/components/suggestions/BUILD.gn
@@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-source_set("suggestions") {
+static_library("suggestions") {
sources = [
"blacklist_store.cc",
"blacklist_store.h",
@@ -21,18 +21,16 @@
"suggestions_utils.h",
]
- public_deps = [
+ deps = [
"//base",
+ "//components/keyed_service/core",
+ "//components/pref_registry",
"//components/suggestions/proto",
+ "//components/variations",
+ "//components/variations/net",
"//net",
"//ui/gfx",
"//url",
- ]
- deps = [
- "//components/keyed_service/core",
- "//components/pref_registry",
- "//components/variations",
- "//components/variations/net",
]
if (is_ios) {
@@ -41,18 +39,3 @@
sources += [ "image_encoder.cc" ]
}
}
-
-source_set("unit_tests") {
- testonly = true
- sources = [
- "blacklist_store_unittest.cc",
- "image_manager_unittest.cc",
- "suggestions_service_unittest.cc",
- "suggestions_store_unittest.cc",
- ]
- deps = [
- ":suggestions",
- "//testing/gmock",
- "//testing/gtest",
- ]
-}
« no previous file with comments | « components/sessions/BUILD.gn ('k') | components/sync_driver/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698