Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1306153002: Revert of Sync more GN unit tests with GYP. (Closed)

Created:
5 years, 4 months ago by nasko
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, wjmaclean, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, browser-components-watch_chromium.org, maxbogue+watch_chromium.org, jam, chromium-apps-reviews_chromium.org, plaree+watch_chromium.org, darin-cc_chromium.org, noyau+watch_chromium.org, asvitkine+watch_chromium.org, tfarina, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, Yuki, henrika (OOO until Aug 14), nasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@tests3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Sync more GN unit tests with GYP. (patchset #3 id:40001 of https://codereview.chromium.org/1301743003/ ) Reason for revert: This has broken the GN builds. Windows is failing compilation and Mac is failing generate_build_files. http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/15185/steps/generate_build_files/logs/stdio http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/5562/steps/compile/logs/stdio Original issue's description: > Sync more GN unit tests with GYP. > > This adds about 600 more tests. > > Tests added: invalidation, navigation interception, feedback, search, sync driver, enhanced bookmarks, search engines, sessions, data reduction proxy, favicon, constrained window, autofill, metrics, keyed service, bookmarks, suggestions, audio modem > > I renamed ui_zoom to "zoom" according to GN style. I tweaked some jingle public dependencies so the right include directories get forwarded along with the corresponding uses in the headers. > > BUG= > R=dpranke@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a7cde4bd39dc814952d885e54eee33ffdac1a881 TBR=dpranke@chromium.org,thestig@chromium.org,msramek@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/5c19af794b141814a2a16c288a00ec1503e7142d Cr-Commit-Position: refs/heads/master@{#344760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -288 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 7 chunks +3 lines, -17 lines 0 comments Download
M components/audio_modem/BUILD.gn View 4 chunks +4 lines, -24 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/bookmarks/browser/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/constrained_window/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M components/enhanced_bookmarks/BUILD.gn View 1 chunk +1 line, -15 lines 0 comments Download
M components/favicon/content/BUILD.gn View 2 chunks +2 lines, -16 lines 0 comments Download
M components/favicon/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/BUILD.gn View 2 chunks +1 line, -17 lines 0 comments Download
M components/guest_view/browser/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M components/invalidation/impl/BUILD.gn View 4 chunks +6 lines, -32 lines 0 comments Download
M components/keyed_service/content/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M components/keyed_service/core/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M components/navigation_interception/BUILD.gn View 2 chunks +1 line, -14 lines 0 comments Download
M components/rappor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/search/BUILD.gn View 2 chunks +1 line, -13 lines 0 comments Download
M components/search_engines/BUILD.gn View 1 chunk +1 line, -20 lines 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M components/suggestions/BUILD.gn View 3 chunks +6 lines, -23 lines 0 comments Download
M components/sync_driver/BUILD.gn View 4 chunks +35 lines, -36 lines 0 comments Download
M components/ui/zoom/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/ui_zoom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_modal/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M jingle/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M pdf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nasko
Created Revert of Sync more GN unit tests with GYP.
5 years, 4 months ago (2015-08-21 14:10:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306153002/1
5 years, 4 months ago (2015-08-21 14:10:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 14:11:32 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 14:12:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c19af794b141814a2a16c288a00ec1503e7142d
Cr-Commit-Position: refs/heads/master@{#344760}

Powered by Google App Engine
This is Rietveld 408576698