|
Revert of Sync more GN unit tests with GYP. (patchset #3 id:40001 of https://codereview.chromium.org/1301743003/ )
Reason for revert:
This has broken the GN builds. Windows is failing compilation and Mac is failing generate_build_files.
http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/15185/steps/generate_build_files/logs/stdio
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/5562/steps/compile/logs/stdio
Original issue's description:
> Sync more GN unit tests with GYP.
>
> This adds about 600 more tests.
>
> Tests added: invalidation, navigation interception, feedback, search, sync driver, enhanced bookmarks, search engines, sessions, data reduction proxy, favicon, constrained window, autofill, metrics, keyed service, bookmarks, suggestions, audio modem
>
> I renamed ui_zoom to "zoom" according to GN style. I tweaked some jingle public dependencies so the right include directories get forwarded along with the corresponding uses in the headers.
>
> BUG=
> R=dpranke@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/a7cde4bd39dc814952d885e54eee33ffdac1a881
TBR=dpranke@chromium.org,thestig@chromium.org,msramek@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/5c19af794b141814a2a16c288a00ec1503e7142d
Cr-Commit-Position: refs/heads/master@{#344760}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+75 lines, -288 lines) |
Patch |
 |
M |
chrome/browser/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/BUILD.gn
|
View
|
|
7 chunks |
+3 lines, -17 lines |
0 comments
|
Download
|
 |
M |
components/audio_modem/BUILD.gn
|
View
|
|
4 chunks |
+4 lines, -24 lines |
0 comments
|
Download
|
 |
M |
components/autofill/core/browser/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/bookmarks/browser/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/components_tests.gyp
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
components/constrained_window/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
components/data_reduction_proxy/core/browser/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
components/enhanced_bookmarks/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -15 lines |
0 comments
|
Download
|
 |
M |
components/favicon/content/BUILD.gn
|
View
|
|
2 chunks |
+2 lines, -16 lines |
0 comments
|
Download
|
 |
M |
components/favicon/core/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/feedback/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -17 lines |
0 comments
|
Download
|
 |
M |
components/guest_view/browser/BUILD.gn
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
components/invalidation/impl/BUILD.gn
|
View
|
|
4 chunks |
+6 lines, -32 lines |
0 comments
|
Download
|
 |
M |
components/keyed_service/content/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
components/keyed_service/core/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
components/metrics/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
components/navigation_interception/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -14 lines |
0 comments
|
Download
|
 |
M |
components/rappor/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/search/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -13 lines |
0 comments
|
Download
|
 |
M |
components/search_engines/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -20 lines |
0 comments
|
Download
|
 |
M |
components/sessions/BUILD.gn
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
components/suggestions/BUILD.gn
|
View
|
|
3 chunks |
+6 lines, -23 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/BUILD.gn
|
View
|
|
4 chunks |
+35 lines, -36 lines |
0 comments
|
Download
|
 |
M |
components/ui/zoom/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/ui_zoom.gypi
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/web_modal/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
extensions/browser/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
jingle/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
pdf/BUILD.gn
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|