Issue 1306133003: GMs: change some GMs to use SkImage over SkBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1306133003: GMs: change some GMs to use SkImage over SkBitmap (Closed)

Created:
5 years, 4 months ago by hal.canary

Modified:
5 years, 4 months ago

Reviewers:
bungeman-skia

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

GMs: change some GMs to use SkImage over SkBitmap Also, add GetResourceAsImage() to Resources.h Motivation: test drawImage() as much as we test drawBitmap() Committed: https://skia.googlesource.com/skia/+/2f0a728e5aed1553811a44c4203b68853255f1bd

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -12 lines)			Patch
M	gm/colorwheel.cpp	View	2 chunks	+9 lines, -8 lines	0 comments	Download
M	gm/grayscalejpg.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/Resources.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tools/Resources.cpp	View	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306133003/1

5 years, 4 months ago (2015-08-21 14:41:11 UTC) #5

commit-bot: I haz the power

5 years, 4 months ago (2015-08-21 14:47:26 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2f0a728e5aed1553811a44c4203b68853255f1bd

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages