Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 130613004: Enabled consumer kiosk mode for all. (Closed)

Created:
6 years, 11 months ago by zel
Modified:
6 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Enabled consumer kiosk mode for all devices. DeviceMode::DEVICE_MODE_CONSUMER_KIOSK is renamed to DeviceMode::DEVICE_MODE_CONSUMER_KIOSK_AUTO_LAUNCH and it is now used to determine if auto-launch if a kiosk app is permitted in consumer kiosk mode. BUG=315297 TEST=existing browser tests - Kiosk* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250301

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : rebase #

Patch Set 8 : #

Patch Set 9 : rebase #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -166 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.h View 1 2 3 3 chunks +21 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager.cc View 1 2 3 4 6 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc View 1 2 3 6 chunks +31 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 2 3 4 5 6 7 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 2 3 4 5 6 7 8 chunks +21 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes.cc View 1 2 3 4 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes_unittest.cc View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/extensions/chromeos/kiosk_app_list.js View 1 2 3 3 chunks +24 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/chromeos/kiosk_apps.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc View 1 2 3 4 5 6 7 4 chunks +1 line, -24 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.cc View 1 2 3 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc View 1 2 3 5 chunks +16 lines, -10 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_constants.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
zel
6 years, 11 months ago (2014-01-23 20:15:19 UTC) #1
zel
+wad
6 years, 11 months ago (2014-01-23 20:17:15 UTC) #2
xiyuan
LGTM https://codereview.chromium.org/130613004/diff/150001/chrome/browser/chromeos/app_mode/kiosk_app_manager.h File chrome/browser/chromeos/app_mode/kiosk_app_manager.h (right): https://codereview.chromium.org/130613004/diff/150001/chrome/browser/chromeos/app_mode/kiosk_app_manager.h#newcode96 chrome/browser/chromeos/app_mode/kiosk_app_manager.h:96: void EnableConsumerModeKioskAutoStart( nit: Can we be consistent with ...
6 years, 11 months ago (2014-01-23 22:05:10 UTC) #3
zel
+mnissler as OWNER for policy stuff https://codereview.chromium.org/130613004/diff/150001/chrome/browser/chromeos/app_mode/kiosk_app_manager.h File chrome/browser/chromeos/app_mode/kiosk_app_manager.h (right): https://codereview.chromium.org/130613004/diff/150001/chrome/browser/chromeos/app_mode/kiosk_app_manager.h#newcode96 chrome/browser/chromeos/app_mode/kiosk_app_manager.h:96: void EnableConsumerModeKioskAutoStart( On ...
6 years, 11 months ago (2014-01-23 22:55:26 UTC) #4
jennyz
lgtm
6 years, 11 months ago (2014-01-23 23:01:45 UTC) #5
Mattias Nissler (ping if slow)
Policy stuff LGTM. I assume we're OK to enable manually-launched Kiosks for everybody then?
6 years, 11 months ago (2014-01-24 08:15:03 UTC) #6
Will Drewry
On 2014/01/24 08:15:03, Mattias Nissler wrote: > Policy stuff LGTM. I assume we're OK to ...
6 years, 11 months ago (2014-01-24 14:55:20 UTC) #7
Will Drewry
On 2014/01/24 08:15:03, Mattias Nissler wrote: > Policy stuff LGTM. I assume we're OK to ...
6 years, 11 months ago (2014-01-24 14:55:22 UTC) #8
zel
On 2014/01/24 14:55:22, Will Drewry wrote: > On 2014/01/24 08:15:03, Mattias Nissler wrote: > > ...
6 years, 10 months ago (2014-02-10 23:38:25 UTC) #9
zel
The CQ bit was checked by zelidrag@chromium.org
6 years, 10 months ago (2014-02-10 23:43:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zelidrag@chromium.org/130613004/660001
6 years, 10 months ago (2014-02-11 00:06:25 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 02:51:42 UTC) #12
Message was sent while issue was closed. 
Change committed as 250301

Powered by Google App Engine
This is Rietveld 408576698