Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306123008: [Android] Remove multidex installation until multidex is deployed. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove multidex installation until multidex is deployed. BUG=525695 Committed: https://crrev.com/8f7bea6a8a3b74f8cbd5eebceca881a292725937 Cr-Commit-Position: refs/heads/master@{#346154}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 2 chunks +0 lines, -3 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
jbudorick
5 years, 3 months ago (2015-08-28 14:29:37 UTC) #2
Yaron
lgtm
5 years, 3 months ago (2015-08-28 14:30:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306123008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306123008/1
5 years, 3 months ago (2015-08-28 14:31:44 UTC) #5
Yaron
https://codereview.chromium.org/1306123008/diff/1/base/android/java/src/org/chromium/base/BaseChromiumApplication.java File base/android/java/src/org/chromium/base/BaseChromiumApplication.java (right): https://codereview.chromium.org/1306123008/diff/1/base/android/java/src/org/chromium/base/BaseChromiumApplication.java#newcode22 base/android/java/src/org/chromium/base/BaseChromiumApplication.java:22: super.attachBaseContext(base); Erm. I do wonder if lint complains about ...
5 years, 3 months ago (2015-08-28 14:32:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 15:42:37 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 15:43:17 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8f7bea6a8a3b74f8cbd5eebceca881a292725937
Cr-Commit-Position: refs/heads/master@{#346154}

Powered by Google App Engine
This is Rietveld 408576698