Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1306073004: Don't NFC normalize filenames in form data (Closed)

Created:
5 years, 3 months ago by jsbell
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't NFC normalize filenames in form data When building the payload for POST data with files, Blink was normalizing strings. Similar to crbug.com/427183, we're calling normalizeAndEncode() when encode() is more appropriate, and matches the behavior in other browsers. BUG=341019 R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
A LayoutTests/http/tests/xmlhttprequest/filename-encoding.html View 1 chunk +43 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/filename-encoding-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/platform/network/FormDataBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jsbell
tkent@ - please take a look? Something in my filesystem/console/etc seems to enjoy normalizing filenames ...
5 years, 3 months ago (2015-09-02 00:00:12 UTC) #1
tkent
lgtm
5 years, 3 months ago (2015-09-02 00:01:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306073004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306073004/1
5 years, 3 months ago (2015-09-02 00:10:59 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 01:00:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201590

Powered by Google App Engine
This is Rietveld 408576698