White-listing Chrome Remote Desktop to use the identity API in Public Session

chrome/browser/extensions/api/identity/identity_api.h

Index: chrome/browser/extensions/api/identity/identity_api.h
diff --git a/chrome/browser/extensions/api/identity/identity_api.h b/chrome/browser/extensions/api/identity/identity_api.h
index a8e4e26d30df31130b168d754b0cd677cf684798..83ae92929b253ecb2232600593165a24e1d63455 100644
--- a/chrome/browser/extensions/api/identity/identity_api.h
+++ b/chrome/browser/extensions/api/identity/identity_api.h
@@ -263,8 +263,12 @@ class IdentityGetAuthTokenFunction : public ChromeAsyncExtensionFunction,
 
 #if defined(OS_CHROMEOS)
   // Starts a login access token request for device robot account. This method
-  // will be called only in enterprise kiosk mode in ChromeOS.
+  // will be called only in ChromeOS for:

[bartfab (slow), 2015/09/18 12:24:57]

Nit: s/ChromeOS/Chrome OS/

[kelvinp, 2015/09/22 00:50:37]

Done.

+  // 1. Enterprise kiosk mode.
+  // 2. Whitelisted first party apps in public session.
   virtual void StartDeviceLoginAccessTokenRequest();
+

[Andrew T Wilson (Slow), 2015/09/18 07:13:29]

Two things:

1) This API should be private, not public.
2) This API should have a test (which maybe is a reason to make it public)

Having it public but not tested is the worst of both worlds :)

[kelvinp, 2015/09/22 00:50:37]

This function is private.  I have added a test case to ensure that
non-whitelisted apps have no access to the device token.

+  bool IsOriginWhitelistedInPublicSession();
 #endif
 
   // Methods for invoking UI. Overridable for testing.