content/test/test_web_contents.cc - Issue 1306053008: Avoid creating a RenderWidgetHostView for proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/test_web_contents.cc

Issue 1306053008: Avoid creating a RenderWidgetHostView for proxies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: recreate WidgetViews when reusing RenderView Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/test/test_web_contents.cc

diff --git a/content/test/test_web_contents.cc b/content/test/test_web_contents.cc

index b7b958ebe78474a116db1301dc42789e524b394c..ca2c6ca192044ae206493e8e214900914ec0b453 100644

--- a/content/test/test_web_contents.cc

+++ b/content/test/test_web_contents.cc

@@ -163,8 +163,7 @@ bool TestWebContents::CreateRenderViewForRenderManager(

RenderViewHost* render_view_host,

int opener_frame_routing_id,

int proxy_routing_id,

- const FrameReplicationState& replicated_frame_state,

- bool for_main_frame) {

+ const FrameReplicationState& replicated_frame_state) {

UpdateMaxPageIDIfNecessary(render_view_host);

// This will go to a TestRenderViewHost.

static_cast<RenderViewHostImpl*>(render_view_host)