content/browser/web_contents/web_contents_impl.h - Issue 1306053008: Avoid creating a RenderWidgetHostView for proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 1306053008: Avoid creating a RenderWidgetHostView for proxies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: recreate WidgetViews when reusing RenderView Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 95eb49a0d0f4e24d12ad23a0eecd02a24dd5f28c..fc6289f03bad0e9a1dee33010114b2364df9c26f 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -587,8 +587,10 @@ class CONTENT_EXPORT WebContentsImpl

RenderViewHost* render_view_host,

int opener_frame_routing_id,

int proxy_routing_id,

- const FrameReplicationState& replicated_frame_state,

- bool for_main_frame_navigation) override;

+ const FrameReplicationState& replicated_frame_state) override;

+ bool CreateRenderWidgetHostViewForRenderManager(

+ RenderViewHost* render_view_host,

+ int proxy_routing_id) override;

bool CreateRenderFrameForRenderManager(RenderFrameHost* render_frame_host,

int parent_routing_id,

int previous_sibling_routing_id,