Avoid creating a RenderWidgetHostView for proxies.

content/browser/renderer_host/render_view_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_view_host_impl.h"
 
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 277 matching lines @@
   // initialized it) or may not (we have our own process or the old process
   // crashed) have been initialized. Calling Init multiple times will be
   // ignored, so this is safe.
   if (!GetProcess()->Init())
     return false;
   DCHECK(GetProcess()->HasConnection());
   DCHECK(GetProcess()->GetBrowserContext());
 
   set_renderer_initialized(true);
 
-  GpuSurfaceTracker::Get()->SetSurfaceHandle(
-      surface_id(), GetCompositingSurface());
+  if (proxy_route_id == MSG_ROUTING_NONE) {
+    GpuSurfaceTracker::Get()->SetSurfaceHandle(surface_id(),
+                                               GetCompositingSurface());
+  } else {
+    GpuSurfaceTracker::Get()->SetSurfaceHandle(

[Charlie Reis, 2015/08/28 18:58:26]

Is this case ever reached?  I don't see a path where it could be.

[lfg, 2015/08/28 21:18:40]

The only place that can call this function with a proxy_routing_id !=
MSG_ROUTING_NONE is CreateRenderViewForRenderManager in WebContentsImpl.

Usually, the SurfaceHandles are set from the RenderWidgetHostView (in SetView).
Since this patch is allowing the creation of a RenderViewHost without a
RenderWidgetHostView, I had to change it to initialize the SurfaceHandle as a
null surface (as opposed to empty, which is initialized above).

+        surface_id(),
+        gfx::GLSurfaceHandle(gfx::kNullPluginWindow, gfx::NULL_TRANSPORT));
+  }
 
   // Ensure the RenderView starts with a next_page_id larger than any existing
   // page ID it might be asked to render.
   int32 next_page_id = 1;
   if (max_page_id > -1)
     next_page_id = max_page_id + 1;
 
   ViewMsg_New_Params params;
   params.renderer_preferences =
       delegate_->GetRendererPrefs(GetProcess()->GetBrowserContext());
@@ skipping 1119 matching lines @@
     if (!policy->CanReadFile(GetProcess()->GetID(), file))
       policy->GrantReadFile(GetProcess()->GetID(), file);
   }
 }
 
 void RenderViewHostImpl::SelectWordAroundCaret() {
   Send(new ViewMsg_SelectWordAroundCaret(GetRoutingID()));
 }
 
 }  // namespace content