Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306043003: Move runtime helper for ToName conversion onto Object. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-heap-friends
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move runtime helper for ToName conversion onto Object. R=bmeurer@chromium.org Committed: https://crrev.com/1dc711f2464efa8484025b6aebac55ada530d255 Cr-Commit-Position: refs/heads/master@{#30409}

Patch Set 1 #

Patch Set 2 : Minor fixup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -27 lines) Patch
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-forin.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 4 chunks +6 lines, -15 lines 0 comments Download

Depends on Patchset:

Issue 1320843002 Patch 40001

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 3 months ago (2015-08-27 12:13:17 UTC) #1
Benedikt Meurer
LGTM!
5 years, 3 months ago (2015-08-27 12:14:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306043003/20001
5 years, 3 months ago (2015-08-27 12:18:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5283)
5 years, 3 months ago (2015-08-27 12:22:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306043003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306043003/20001
5 years, 3 months ago (2015-08-27 12:36:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 12:50:35 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 12:50:53 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1dc711f2464efa8484025b6aebac55ada530d255
Cr-Commit-Position: refs/heads/master@{#30409}

Powered by Google App Engine
This is Rietveld 408576698