Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1306033009: Don't clobber the PATH environment variable when running git commit. (Closed)

Created:
5 years, 3 months ago by dsansome
Modified:
5 years, 3 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/testing_support.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't clobber the PATH environment variable when running git commit. OS X comes with an old version of Python, so we install a newer one in /usr/local/git/bin and add that to the PATH in the build step. The old version that comes with OS X doesn't understand the timezone in GIT_*_DATE environment variables, so always creates commits in the local timezone (US/Pacific). This leads to commits with different hashes to what the test was expecting, causing failures on OS X 10.6 and 10.7: http://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.6-64/builds/3/steps/infra%20python%20tests/logs/stdio BUG= R=vadimsh@chromium.org Committed: https://chromium.googlesource.com/infra/testing/testing_support/+/3bb4723ba5de249411172b63de6112461a8278d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M testing_support/git/repo.py View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dsansome
5 years, 3 months ago (2015-09-08 07:23:08 UTC) #2
dsansome
Oops, pgervais is OOO. Could you take a look at this instead?
5 years, 3 months ago (2015-09-08 22:35:12 UTC) #4
Vadim Sh.
lgtm
5 years, 3 months ago (2015-09-08 22:41:01 UTC) #5
dsansome
5 years, 3 months ago (2015-09-08 22:43:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3bb4723ba5de249411172b63de6112461a8278d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698