Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306013004: [DevTools] Fixed content scripts (Closed)

Created:
5 years, 3 months ago by kozy
Modified:
5 years, 3 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
A LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html View 1 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/sources-panel-content-scripts-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/inspector/DebuggerScript.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
kozy
ptal!
5 years, 3 months ago (2015-08-28 20:18:48 UTC) #1
yurys
lgtm with nits https://codereview.chromium.org/1306013004/diff/1/LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html File LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html (right): https://codereview.chromium.org/1306013004/diff/1/LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html#newcode16 LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html:16: var scripts = InspectorTest.queryScripts(function(script) { return ...
5 years, 3 months ago (2015-08-28 20:23:47 UTC) #2
kozy
All done. https://codereview.chromium.org/1306013004/diff/1/LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html File LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html (right): https://codereview.chromium.org/1306013004/diff/1/LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html#newcode16 LayoutTests/inspector/sources/debugger/sources-panel-content-scripts.html:16: var scripts = InspectorTest.queryScripts(function(script) { return script._isContentScript; ...
5 years, 3 months ago (2015-08-28 20:24:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306013004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306013004/20001
5 years, 3 months ago (2015-08-28 20:24:22 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 21:36:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201427

Powered by Google App Engine
This is Rietveld 408576698