Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1306003002: Make classes and structures in core/editing fast-allocated. (Closed)

Created:
5 years, 4 months ago by tasak
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, groby+blinkspell_chromium.org, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/editing fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200988

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M Source/core/editing/CompositionUnderline.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/CompositionUnderlineRangeFilter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/editing/EditingBehavior.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/EditingStrategy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/editing/EditingStyle.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingTestBase.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/GranularityStrategy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/InputMethodController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/PlainTextRange.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/editing/RenderedPosition.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/editing/SurroundingText.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/editing/commands/UndoStack.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/iterators/BitStack.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/editing/iterators/FullyClippedStateStack.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/editing/iterators/SearchBuffer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/editing/spellcheck/SpellChecker.h View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
tasak
Would you review this CL?
5 years, 4 months ago (2015-08-21 07:48:22 UTC) #2
haraken
LGTM Let's create a tracking bug for the allocator replacement. https://codereview.chromium.org/1306003002/diff/1/Source/core/editing/spellcheck/SpellChecker.h File Source/core/editing/spellcheck/SpellChecker.h (right): https://codereview.chromium.org/1306003002/diff/1/Source/core/editing/spellcheck/SpellChecker.h#newcode48 ...
5 years, 4 months ago (2015-08-21 07:52:45 UTC) #3
tasak
Thank you for review. On 2015/08/21 07:52:45, haraken wrote: > LGTM > > Let's create ...
5 years, 4 months ago (2015-08-21 10:01:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1306003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1306003002/1
5 years, 4 months ago (2015-08-21 10:02:12 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 14:58:40 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200988

Powered by Google App Engine
This is Rietveld 408576698