Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_ibus.cc

Issue 13060003: Extract Extension IME related utility. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_engine_ibus.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc b/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc
index 9a81aa518cffe7d8057380019bc558182b428cf8..874a5c362df49a896d64f1327d8c6925395381bd 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc
@@ -24,11 +24,11 @@
#include "chromeos/dbus/ibus/ibus_lookup_table.h"
#include "chromeos/dbus/ibus/ibus_property.h"
#include "chromeos/dbus/ibus/ibus_text.h"
+#include "chromeos/ime/extension_ime_util.h"
#include "chromeos/ime/ibus_keymap.h"
#include "dbus/object_path.h"
namespace chromeos {
-const char* kExtensionImePrefix = "_ext_ime_";
const char* kErrorNotActive = "IME is not active";
const char* kErrorWrongContext = "Context is not active";
const char* kCandidateNotFound = "Candidate not found";
@@ -78,9 +78,7 @@ void InputMethodEngineIBus::Initialize(
observer_ = observer;
engine_id_ = engine_id;
- ibus_id_ = kExtensionImePrefix;
- ibus_id_ += extension_id;
- ibus_id_ += engine_id;
+ ibus_id_ = extension_ime_util::GetInputMethodID(extension_id, engine_id);
input_method::InputMethodManager* manager =
input_method::GetInputMethodManager();

Powered by Google App Engine
This is Rietveld 408576698