Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: runtime/vm/regexp.cc

Issue 1305993005: VM: Simplify irregexp entry stub. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: simplify ExecuteMatch Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/regexp_assembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/regexp.cc
diff --git a/runtime/vm/regexp.cc b/runtime/vm/regexp.cc
index f20e0152394524874477d4045732db9a31864d4f..f58137c8e6efb7f1a392d0b9161f038c1487f3e9 100644
--- a/runtime/vm/regexp.cc
+++ b/runtime/vm/regexp.cc
@@ -5275,10 +5275,18 @@ static void CreateSpecializedFunction(Zone* zone,
Heap::kOld)));
fn.set_parameter_names(Array::Handle(zone, Array::New(kParamCount,
Heap::kOld)));
- fn.SetParameterTypeAt(0, Type::Handle(zone, Type::DynamicType()));
- fn.SetParameterNameAt(0, Symbols::string_param());
- fn.SetParameterTypeAt(1, Type::Handle(zone, Type::DynamicType()));
- fn.SetParameterNameAt(1, Symbols::start_index_param());
+ fn.SetParameterTypeAt(RegExpMacroAssembler::kParamRegExpIndex,
+ Type::Handle(zone, Type::DynamicType()));
+ fn.SetParameterNameAt(RegExpMacroAssembler::kParamRegExpIndex,
+ Symbols::This());
+ fn.SetParameterTypeAt(RegExpMacroAssembler::kParamStringIndex,
+ Type::Handle(zone, Type::DynamicType()));
+ fn.SetParameterNameAt(RegExpMacroAssembler::kParamStringIndex,
+ Symbols::string_param());
+ fn.SetParameterTypeAt(RegExpMacroAssembler::kParamStartOffsetIndex,
+ Type::Handle(zone, Type::DynamicType()));
+ fn.SetParameterNameAt(RegExpMacroAssembler::kParamStartOffsetIndex,
+ Symbols::start_index_param());
fn.set_result_type(Type::Handle(zone, Type::ArrayType()));
// Cache the result.
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/regexp_assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698