Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1305973007: Clean up empty namespace handling and fix empty namespaces in compound selectors (Closed)

Created:
5 years, 3 months ago by Timothy Loh
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@defaultns
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up empty namespace handling and fix empty namespaces in compound selectors This patch makes our namespace handling code in selector parsing to use emptyAtom to represent empty namespaces and nullAtom to represent no namespace (e.g. "|a" vs. "a"), instead of having both as nullAtom and a separate hasNamespace bool. This fixes a bug where we would interpret in prependTypeSelectorIfNeeded an empty namespace as no namespace (i.e. the default namespace). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201755

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -29 lines) Patch
M LayoutTests/fast/css/css-selector-text.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/css-selector-text-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/css-set-selector-text.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/css-set-selector-text-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-1.xhtml View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-2.xhtml View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/css/CSSSelectorList.cpp View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSSelectorParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 1 7 chunks +11 lines, -18 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (6 generated)
Timothy Loh
This depends on https://codereview.chromium.org/1322543004... also probably no one ever uses empty namespaces or will notice ...
5 years, 3 months ago (2015-09-03 07:23:06 UTC) #2
alancutter (OOO until 2018)
lgtm with int. https://codereview.chromium.org/1305973007/diff/20001/LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-1.xhtml File LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-1.xhtml (right): https://codereview.chromium.org/1305973007/diff/20001/LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-1.xhtml#newcode16 LayoutTests/fast/css/namespaces/empty-namespace-compound-selector-1.xhtml:16: <Y id="div" xmlns=""></Y> Tagname "div" with ...
5 years, 3 months ago (2015-09-03 07:43:23 UTC) #3
Timothy Loh
I fixed up a couple more things: - Updated tests which expected '|a' to serialize ...
5 years, 3 months ago (2015-09-03 08:35:05 UTC) #4
alancutter (OOO until 2018)
lgtm
5 years, 3 months ago (2015-09-03 08:40:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305973007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305973007/60001
5 years, 3 months ago (2015-09-03 09:11:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/96086)
5 years, 3 months ago (2015-09-03 09:16:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305973007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305973007/60001
5 years, 3 months ago (2015-09-03 09:24:28 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/96089)
5 years, 3 months ago (2015-09-03 09:29:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305973007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305973007/60001
5 years, 3 months ago (2015-09-04 00:46:00 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 00:50:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201755

Powered by Google App Engine
This is Rietveld 408576698