Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 1305973002: Revert of Fix autoplay during prerendering for media elements on Android. (Closed)

Created:
5 years, 4 months ago by Yuki
Modified:
5 years, 4 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@defer_media
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix autoplay during prerendering for media elements on Android. (patchset #4 id:60001 of https://codereview.chromium.org/1293253003/ ) Reason for revert: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/92412/steps/compile/logs/stdio This CL seems redefining MediaBrowserTest, which is already defined in chrome/browser/media/media_browsertest.h and causing build breakage. Original issue's description: > Fix autoplay during prerendering for media elements on Android. > > If the user gesture for autoplay is disabled manually or via an > experiment, prerendered media will play in a hidden frame. > > Within WebMediaPlayerImpl this behavior is deferred at load time > via a callback, however WebMediaPlayerAndroid was never given > this callback, so it would try to play media. Generally this > fails because by default autoplay requires a user gesture. > > The correct fix is to refactor WMPA such that it uses a params > structure like WMPI and can invoke the deferral callback when > load() is called. > > BUG=522157 > TEST=clank no longer plays hidden a/v when user gesture disabled. > > Committed: https://crrev.com/98fc72cda10bf328ad55e460f6a7b06a356d5b3d > Cr-Commit-Position: refs/heads/master@{#344676} TBR=creis@chromium.org,qinmin@chromium.org,dalecurtis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=522157 Committed: https://crrev.com/1b09bd614c0387158777f703cdb675384a35add3 Cr-Commit-Position: refs/heads/master@{#344682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -74 lines) Patch
M chrome/browser/media/defer_background_media_browsertest.cc View 2 chunks +5 lines, -11 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 5 chunks +5 lines, -11 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 7 chunks +17 lines, -29 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 5 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Yuki
Created Revert of Fix autoplay during prerendering for media elements on Android.
5 years, 4 months ago (2015-08-21 05:21:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305973002/1
5 years, 4 months ago (2015-08-21 05:22:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 05:24:09 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 05:24:45 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b09bd614c0387158777f703cdb675384a35add3
Cr-Commit-Position: refs/heads/master@{#344682}

Powered by Google App Engine
This is Rietveld 408576698