Source/platform/fonts/shaping/SimpleShaper.h - Issue 1305953003: Find In Page doesn't correctly highlight wrapped text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/SimpleShaper.h

Issue 1305953003: Find In Page doesn't correctly highlight wrapped text. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated LayoutTest as suggested by wkorman Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/repaint/text-match-pre-wrapped-text-expected.html ('k') | Source/platform/fonts/shaping/SimpleShaper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/shaping/SimpleShaper.h

diff --git a/Source/platform/fonts/shaping/SimpleShaper.h b/Source/platform/fonts/shaping/SimpleShaper.h

index 83235bd9f5fba533dd1729106ec10d062b214f44..435fac0644c7ffa64df8c1bb277e7aa5a0a39181 100644

--- a/Source/platform/fonts/shaping/SimpleShaper.h

+++ b/Source/platform/fonts/shaping/SimpleShaper.h

@@ -45,7 +45,9 @@ public:

SimpleShaper(const Font*, const TextRun&, const GlyphData* emphasisData = nullptr,

HashSet<const SimpleFontData*>* fallbackFonts = nullptr, FloatRect* = nullptr);

- unsigned advance(unsigned to, GlyphBuffer* = 0);

+ // TODO(sk.kumar): This function should be updated to take an unsigned value, and callers

+ // should be updated to not pass negative values. See: crbug.com/540047.

+ unsigned advance(int to, GlyphBuffer* = 0);

bool advanceOneCharacter(float& width);

const TextRun& run() const { return m_textRun; }