Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: Source/platform/fonts/shaping/SimpleShaper.h

Issue 1305953003: Find In Page doesn't correctly highlight wrapped text. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/fonts/shaping/SimpleShaper.h
diff --git a/Source/platform/fonts/shaping/SimpleShaper.h b/Source/platform/fonts/shaping/SimpleShaper.h
index 83235bd9f5fba533dd1729106ec10d062b214f44..415a231c45db270c5155555ebf53e3664c9d1bb1 100644
--- a/Source/platform/fonts/shaping/SimpleShaper.h
+++ b/Source/platform/fonts/shaping/SimpleShaper.h
@@ -45,7 +45,7 @@ public:
SimpleShaper(const Font*, const TextRun&, const GlyphData* emphasisData = nullptr,
HashSet<const SimpleFontData*>* fallbackFonts = nullptr, FloatRect* = nullptr);
- unsigned advance(unsigned to, GlyphBuffer* = 0);
+ unsigned advance(int to, GlyphBuffer* = 0);
pdr. 2015/10/06 23:07:07 Can you also add a comment that we need to fix thi
bool advanceOneCharacter(float& width);
const TextRun& run() const { return m_textRun; }

Powered by Google App Engine
This is Rietveld 408576698