LayoutTests/fast/repaint/text-match-pre-wrapped-text.html - Issue 1305953003: Find In Page doesn't correctly highlight wrapped text.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/repaint/text-match-pre-wrapped-text.html

Issue 1305953003: Find In Page doesn't correctly highlight wrapped text. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <script>	2 <script>

3 function highlightRange(id, start, end, active) {	3 function highlightRange(id, start, end, active) {

4 var range = document.createRange();	4 var range = document.createRange();

5 var elem = document.getElementById(id).firstChild;	5 var elem = document.getElementById(id).firstChild;

6 range.setStart(elem, start);	6 range.setStart(elem, start);

7 range.setEnd(elem, end);	7 range.setEnd(elem, end);

8 window.internals.addTextMatchMarker(range, active);	8 window.internals.addTextMatchMarker(range, active);

9 window.internals.setMarkedTextMatchesAreHighlighted(document, true);	9 window.internals.setMarkedTextMatchesAreHighlighted(document, true);

10 }	10 }

11 function highlightTest() {	11 function highlightTest() {

12 highlightRange('1', 2, 5, true);	12 highlightRange('1', 53, 60, true);

13 }	13 }

14 </script>	14 </script>

15	15

16 <body onload="highlightTest()">	16 <body onload="highlightTest()">

17 Test for crbug.com/504712	17 Test for crbug.com/521047

18 <p>Find In Page: The below transparent text "ndM" from findMe should be highligh ted as orange and painted as black</p>	18 <pre id="1" style="max-width:460px; white-space:pre-wrap">Find In Page should co rrectly highlight wrapped text Find Me </pre>

19 <span id="1" style="color:transparent">findMe</span>

20 </body>	19 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/repaint/text-match-pre-wrapped-text-expected.html » ('j') | Source/platform/fonts/shaping/SimpleShaper.h » ('J')