Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1305943008: X87: [es6] Re-implement rest parameters via desugaring. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Re-implement rest parameters via desugaring. port 510baeacbab311798d5e8795800ff773d00d062c (r30550) original commit message: Kills the kRestParameter bailout/disabled optimization, and fixes lazily parsed arrow functions with rest parameters. Supercedes https://crrev.com/1235153006/ BUG= Committed: https://crrev.com/e5ee42fa05fdc30b75cd575366cbba292e94f022 Cr-Commit-Position: refs/heads/master@{#30608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -49 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-06 10:20:15 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-07 07:17:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305943008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305943008/1
5 years, 3 months ago (2015-09-07 07:17:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 07:51:31 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 07:51:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5ee42fa05fdc30b75cd575366cbba292e94f022
Cr-Commit-Position: refs/heads/master@{#30608}

Powered by Google App Engine
This is Rietveld 408576698