Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305933006: Document CrossThreadWeakPersistent. (Closed)

Created:
5 years, 3 months ago by Jeffrey Yasskin
Modified:
5 years, 3 months ago
Reviewers:
haraken, sof, Yuta Kitamura
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pinned
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Document CrossThreadWeakPersistent. This helps people who follow a link directly to the class without reading its file top-down. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/platform/heap/Handle.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jeffrey Yasskin
5 years, 3 months ago (2015-09-02 15:33:57 UTC) #2
sof
lgtm
5 years, 3 months ago (2015-09-02 15:37:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305933006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305933006/1
5 years, 3 months ago (2015-09-02 16:23:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201655
5 years, 3 months ago (2015-09-02 17:35:06 UTC) #7
haraken
5 years, 3 months ago (2015-09-02 23:35:53 UTC) #8
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698