Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1305923005: [simd.js] Disable SIMD polyfill. (Closed)

Created:
5 years, 3 months ago by gdeepti1
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simd.js] Disable SIMD polyfill. Disable the polyfill in simd.js tests as the functions for Phase 1 have been implemented. BUG=v8:4124 LOG=N R=bbudge@chromium.org, bmeurer@chromium.org, littledan@chromium.org Committed: https://crrev.com/749ba3a13558cb018a2ec783e5dfb56d2f8528d8 Cr-Commit-Position: refs/heads/master@{#30452} Committed: https://crrev.com/c97069e4a4351e86af0db55b2b9c3e5a0b56b8db Cr-Commit-Position: refs/heads/master@{#30527}

Patch Set 1 #

Patch Set 2 : Bill's comment #

Patch Set 3 : Reopening issue, fix for performance tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M test/simdjs/SimdJs.json View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M test/simdjs/generate.py View 1 chunk +0 lines, -1 line 0 comments Download
M test/simdjs/harness-adapt.js View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (5 generated)
gdeepti1
5 years, 3 months ago (2015-08-27 21:10:38 UTC) #1
Dan Ehrenberg
lgtm
5 years, 3 months ago (2015-08-27 21:15:38 UTC) #2
bbudge
Removing myself and adding Brad since he has a better understanding of how the tests ...
5 years, 3 months ago (2015-08-27 21:19:44 UTC) #4
bbudge
Actually remove myself.
5 years, 3 months ago (2015-08-27 21:20:24 UTC) #5
bbudge
LGTM but it would be nice to leave some indication of how to add them ...
5 years, 3 months ago (2015-08-27 21:23:57 UTC) #6
Benedikt Meurer
LGTM
5 years, 3 months ago (2015-08-28 05:48:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305923005/20001
5 years, 3 months ago (2015-08-28 17:48:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-28 18:48:45 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/749ba3a13558cb018a2ec783e5dfb56d2f8528d8 Cr-Commit-Position: refs/heads/master@{#30452}
5 years, 3 months ago (2015-08-28 18:48:57 UTC) #12
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1308003003/ by machenbach@chromium.org. ...
5 years, 3 months ago (2015-08-31 11:58:57 UTC) #13
gdeepti1
PTAL. Added --harmony-simd flag to SimdJs.json to fix performance tests.
5 years, 3 months ago (2015-09-01 21:48:17 UTC) #14
Dan Ehrenberg
lgtm
5 years, 3 months ago (2015-09-01 21:50:41 UTC) #15
Dan Ehrenberg
I think you'll have to upload a separate, new patch to commit this.
5 years, 3 months ago (2015-09-01 21:51:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305923005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305923005/40001
5 years, 3 months ago (2015-09-01 21:58:01 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-01 22:24:55 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 22:25:08 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c97069e4a4351e86af0db55b2b9c3e5a0b56b8db
Cr-Commit-Position: refs/heads/master@{#30527}

Powered by Google App Engine
This is Rietveld 408576698