Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: util/mach/mach_extensions.h

Issue 1305893010: Don’t trigger EXC_CORPSE_NOTIFY on OS X 10.11 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/exception_ports_test.cc ('k') | util/mach/mach_extensions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/mach_extensions.h
diff --git a/util/mach/mach_extensions.h b/util/mach/mach_extensions.h
index d1e392ad7a55f90682f8bed1bc1618816eb7aa1a..4f2861bf6446e2be186e3c6bc31956e970aa1c3b 100644
--- a/util/mach/mach_extensions.h
+++ b/util/mach/mach_extensions.h
@@ -94,11 +94,27 @@ mach_port_t NewMachPort(mach_port_right_t right);
//! recognize. Calling this function will return a value for `EXC_MASK_ALL`
//! appropriate for the system at run time.
//!
-//! \note `EXC_MASK_ALL` does not include the value of `EXC_MASK_CRASH`.
-//! Consumers that want `EXC_MASK_ALL` along with `EXC_MASK_CRASH` must use
-//! ExcMaskAll() | `EXC_MASK_CRASH` explicitly.
+//! \note `EXC_MASK_ALL` does not include the value of `EXC_MASK_CRASH` or
+//! `EXC_MASK_CORPSE_NOTIFY`. Consumers that want `EXC_MASK_ALL` along with
+//! `EXC_MASK_CRASH` may use ExcMaskAll() `| EXC_MASK_CRASH`. Consumers may
+//! use ExcMaskValid() for `EXC_MASK_ALL` along with `EXC_MASK_CRASH`,
+//! `EXC_MASK_CORPSE_NOTIFY`, and any values that come into existence in the
+//! future.
exception_mask_t ExcMaskAll();
+//! \brief An exception mask containing every possible exception understood by
+//! the operating system at run time.
+//!
+//! `EXC_MASK_ALL`, and thus ExcMaskAll(), never includes the value of
+//! `EXC_MASK_CRASH` or `EXC_MASK_CORPSE_NOTIFY`. For situations where an
+//! exception mask corresponding to every possible exception understood by the
+//! running kernel is desired, use this function instead.
+//!
+//! Should new exception types be introduced in the future, this function will
+//! be updated to include their bits in the returned mask value when run time
+//! support is present.
+exception_mask_t ExcMaskValid();
+
} // namespace crashpad
#endif // CRASHPAD_UTIL_MACH_MACH_EXTENSIONS_H_
« no previous file with comments | « util/mach/exception_ports_test.cc ('k') | util/mach/mach_extensions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698