snapshot/mac/mach_o_image_annotations_reader_test.cc - Issue 1305893010: Don’t trigger EXC_CORPSE_NOTIFY on OS X 10.11

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/mac/mach_o_image_annotations_reader_test.cc

Issue 1305893010: Don’t trigger EXC_CORPSE_NOTIFY on OS X 10.11 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/mac/mach_o_image_annotations_reader_test.cc

diff --git a/snapshot/mac/mach_o_image_annotations_reader_test.cc b/snapshot/mac/mach_o_image_annotations_reader_test.cc

index 6609b059672b908a1220b98edf13fcff9b76b2f5..32f3b5c052987a62f86b5373e9662d10b75a65e5 100644

--- a/snapshot/mac/mach_o_image_annotations_reader_test.cc

+++ b/snapshot/mac/mach_o_image_annotations_reader_test.cc

@@ -218,7 +218,9 @@ class TestMachOImageAnnotationsReader final

}

- return ExcServerSuccessfulReturnValue(behavior, false);

+ ExcServerCopyState(

+ behavior, old_state, old_state_count, new_state, new_state_count);

+ return ExcServerSuccessfulReturnValue(exception, behavior, false);

}

private:

« no previous file with comments | « handler/mac/crash_report_exception_handler.cc ('k') | tools/mac/catch_exception_tool.cc » ('j') | no next file with comments »