client/simulate_crash_mac_test.cc - Issue 1305893010: Don’t trigger EXC_CORPSE_NOTIFY on OS X 10.11

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/simulate_crash_mac_test.cc

Issue 1305893010: Don’t trigger EXC_CORPSE_NOTIFY on OS X 10.11 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Address review feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/simulate_crash_mac_test.cc

diff --git a/client/simulate_crash_mac_test.cc b/client/simulate_crash_mac_test.cc

index e585838ae34fb685a89ca990e513291c8b592fb0..7e0109a3f3f033dc692828f3cf826191551c91e8 100644

--- a/client/simulate_crash_mac_test.cc

+++ b/client/simulate_crash_mac_test.cc

@@ -228,7 +228,7 @@ class TestSimulateCrashMac final : public MachMultiprocess,

ExcServerCopyState(

behavior, old_state, old_state_count, new_state, new_state_count);

- return ExcServerSuccessfulReturnValue(behavior, true);

+ return ExcServerSuccessfulReturnValue(exception, behavior, true);

}

private:

« no previous file with comments | « client/crashpad_client_mac.cc ('k') | compat/mac/AvailabilityMacros.h » ('j') | no next file with comments »