Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1305893006: view-manager: Fix some issues regarding running tests in x11. (Closed)

Created:
5 years, 3 months ago by sadrul
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

view-manager: Fix some issues regarding running tests in x11. During testing, some X11 windows do not get mapped at all (for as yet not-understood reasons). So the calls to BlockUntilWindowMapped() blocks indefinitely. So set the override_redirect flag on when creating windows in tests. Also: . Trigger PlatformWindowDelegate::OnAcceleratedWidgetAvailable() after mapping the window completes. . Initialize aura::Env after initializing GL. . Remove the --use-test-config flag, and instead replace with a combination of --use-x11-test-config to set-up X11 for tests (threaded, and turn on override_redirect), and the existing --override-use-gl-with-osmesa-for-tests. BUG=523144 Committed: https://crrev.com/f33f4399b40b281758038d237416e3560aca4e0c Cr-Commit-Position: refs/heads/master@{#346948}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M components/view_manager/public/cpp/args.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/cpp/lib/args.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M components/view_manager/view_manager_app.cc View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M mojo/tools/data/apptests View 1 2 3 chunks +4 lines, -1 line 0 comments Download
M ui/platform_window/x11/x11_window.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sadrul
5 years, 3 months ago (2015-09-02 15:02:05 UTC) #2
sky
LGTM https://codereview.chromium.org/1305893006/diff/40001/components/view_manager/public/cpp/lib/args.cc File components/view_manager/public/cpp/lib/args.cc (right): https://codereview.chromium.org/1305893006/diff/40001/components/view_manager/public/cpp/lib/args.cc#newcode12 components/view_manager/public/cpp/lib/args.cc:12: const char kUseX11TestConfig[] = "use-x11-test-config"; Document what this ...
5 years, 3 months ago (2015-09-02 15:43:17 UTC) #3
sadrul
https://codereview.chromium.org/1305893006/diff/40001/components/view_manager/public/cpp/lib/args.cc File components/view_manager/public/cpp/lib/args.cc (right): https://codereview.chromium.org/1305893006/diff/40001/components/view_manager/public/cpp/lib/args.cc#newcode12 components/view_manager/public/cpp/lib/args.cc:12: const char kUseX11TestConfig[] = "use-x11-test-config"; On 2015/09/02 15:43:17, sky ...
5 years, 3 months ago (2015-09-02 16:06:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305893006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305893006/60001
5 years, 3 months ago (2015-09-02 16:07:13 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-02 17:12:17 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/f33f4399b40b281758038d237416e3560aca4e0c Cr-Commit-Position: refs/heads/master@{#346948}
5 years, 3 months ago (2015-09-02 17:13:09 UTC) #9
msw
5 years, 3 months ago (2015-09-02 20:30:08 UTC) #10
Message was sent while issue was closed.
This broke view manager apptests on Android:
http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android/...

Powered by Google App Engine
This is Rietveld 408576698