Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1305893003: Remove redundant UMA metrics for context menus. (Closed)

Created:
5 years, 4 months ago by newt (away)
Modified:
5 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant UMA metrics for context menus. These have been superseded by the ContextMenu.SelectedOption histograms added in https://codereview.chromium.org/1267213002 BUG=483685 Committed: https://crrev.com/1b516c688d740ecdb913408e1d186932cabaa6fd Cr-Commit-Position: refs/heads/master@{#345924}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -93 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java View 1 5 chunks +3 lines, -93 lines 0 comments Download
M tools/metrics/actions/actions.xml View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
newt (away)
PTAL
5 years, 4 months ago (2015-08-25 00:16:39 UTC) #2
newt (away)
friendly ping
5 years, 3 months ago (2015-08-26 21:20:17 UTC) #3
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/1305893003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java File chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java (right): https://codereview.chromium.org/1305893003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java#newcode592 chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java:592: if (isLink && shouldInterceptContextMenuDownload(url)) { Could this just ...
5 years, 3 months ago (2015-08-26 21:42:43 UTC) #4
newt (away)
Thanks for the review, neighbor :) https://codereview.chromium.org/1305893003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java File chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java (right): https://codereview.chromium.org/1305893003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java#newcode592 chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java:592: if (isLink && ...
5 years, 3 months ago (2015-08-26 21:48:54 UTC) #5
newt (away)
+asvitkine for actions.xml
5 years, 3 months ago (2015-08-26 21:49:56 UTC) #7
Alexei Svitkine (slow)
lgtm
5 years, 3 months ago (2015-08-27 16:46:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305893003/1
5 years, 3 months ago (2015-08-27 16:56:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/62274) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-08-27 16:58:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305893003/20001
5 years, 3 months ago (2015-08-27 17:16:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 18:16:06 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 18:17:25 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b516c688d740ecdb913408e1d186932cabaa6fd
Cr-Commit-Position: refs/heads/master@{#345924}

Powered by Google App Engine
This is Rietveld 408576698