pkg/compiler/lib/src/cps_ir/insert_refinements.dart - Issue 1305863010: dart2js cps: Store the TypeMask for each primitive in a field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/insert_refinements.dart

Issue 1305863010: dart2js cps: Store the TypeMask for each primitive in a field. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/insert_refinements.dart

diff --git a/pkg/compiler/lib/src/cps_ir/insert_refinements.dart b/pkg/compiler/lib/src/cps_ir/insert_refinements.dart

index e71c52883857dfb1852b66d8310c0eba03b8c1eb..ec12543275f6e585eb251b777b09d364a4ace61f 100644

--- a/pkg/compiler/lib/src/cps_ir/insert_refinements.dart

+++ b/pkg/compiler/lib/src/cps_ir/insert_refinements.dart

@@ -163,7 +163,7 @@ class InsertRefinements extends RecursiveVisitor implements Pass {

// If the condition is an 'is' check, promote the checked value.

if (condition is TypeTest) {

Primitive value = condition.value.definition;

- TypeMask type = types.subtypesOf(condition.type);

+ TypeMask type = types.subtypesOf(condition.dartType);

Primitive refinedValue = new Refinement(value, type);

pushRefinement(trueCont, refinedValue);

push(falseCont);