Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart

Issue 1305863010: dart2js cps: Store the TypeMask for each primitive in a field. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Print type in CPS IR tracer Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
index 1131ce8ab1ebf6f129a045621072b5a1382774e2..631e909e1874864b1f48741e255e795816aced4f 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart
@@ -159,8 +159,8 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
// constructor calls in the DartBackend, we get an element with no enclosing
// class. Clean this up by introducing a name field to the node and
// removing [ErroneousElement]s from the IR.
- if (node.type != null) {
- className = node.type.toString();
+ if (node.dartType != null) {
+ className = node.dartType.toString();
} else {
className = node.target.enclosingClass.name;
}
@@ -232,13 +232,14 @@ class SExpressionStringifier extends Indentation implements Visitor<String> {
String value = access(node.value);
String cont = access(node.continuation);
String typeArguments = node.typeArguments.map(access).join(' ');
- return '$indentation(TypeCast $value ${node.type} ($typeArguments) $cont)';
+ return '$indentation(TypeCast $value ${node.dartType}'
+ ' ($typeArguments) $cont)';
}
String visitTypeTest(TypeTest node) {
String value = access(node.value);
String typeArguments = node.typeArguments.map(access).join(' ');
- return '(TypeTest $value ${node.type} ($typeArguments))';
+ return '(TypeTest $value ${node.dartType} ($typeArguments))';
}
String visitLiteralList(LiteralList node) {

Powered by Google App Engine
This is Rietveld 408576698