Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: remoting/tools/javascript_key_tester/pnacl/BUILD.gn

Issue 1305863002: GN: Enable PNaCl plugin compilation for the key_tester app. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/tools/javascript_key_tester/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/tools/javascript_key_tester/pnacl/BUILD.gn
diff --git a/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn b/remoting/tools/javascript_key_tester/pnacl/BUILD.gn
similarity index 53%
copy from ppapi/native_client/src/untrusted/irt_stub/BUILD.gn
copy to remoting/tools/javascript_key_tester/pnacl/BUILD.gn
index 484145f49e7cc9477c3c0d7065725f166a998994..6ce4081414bfe2f5b5218a526dcc5fe3622ee23f 100644
--- a/ppapi/native_client/src/untrusted/irt_stub/BUILD.gn
+++ b/remoting/tools/javascript_key_tester/pnacl/BUILD.gn
@@ -5,13 +5,13 @@
assert(is_nacl,
"These targets must only be built using the untrusted NaCl toolchains.")
-# TODO(sbc): Make sure this library gets built with -fPIC. Right now it
-# doesn't seem that is built at all.
-source_set("ppapi_stub_lib") {
+executable("remoting_key_tester_newlib") {
sources = [
- "plugin_main_irt.c",
- "ppapi_plugin_main.c",
- "ppapi_plugin_start.c",
- "thread_creator.c",
+ "remoting_key_tester.cc",
+ ]
+
+ deps = [
+ "//ppapi/native_client:ppapi_lib",
+ "//ppapi/cpp",
]
}
« no previous file with comments | « remoting/tools/javascript_key_tester/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698