Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1305863002: GN: Enable PNaCl plugin compilation for the key_tester app. (Closed)

Created:
5 years, 4 months ago by Sergey Ulanov
Modified:
5 years, 4 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Enable PNaCl plugin compilation for the key_tester app. BUG=512899 Committed: https://crrev.com/f6cd4ae2ae3e50081aea80c7629bbd2498c417c6 Cr-Commit-Position: refs/heads/master@{#344606}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -60 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/BUILD.gn View 2 chunks +1 line, -49 lines 0 comments Download
A remoting/tools/javascript_key_tester/BUILD.gn View 1 chunk +48 lines, -0 lines 0 comments Download
A + remoting/tools/javascript_key_tester/pnacl/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
5 years, 4 months ago (2015-08-20 21:38:39 UTC) #2
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-20 21:44:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305863002/20001
5 years, 4 months ago (2015-08-20 21:48:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-20 23:00:03 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 23:00:48 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f6cd4ae2ae3e50081aea80c7629bbd2498c417c6
Cr-Commit-Position: refs/heads/master@{#344606}

Powered by Google App Engine
This is Rietveld 408576698