Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 130583003: Added script optimize-ico-files. (Closed)

Created:
6 years, 11 months ago by Matt Giuca
Modified:
5 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added script optimize-ico-files. This is like the existing optimize-png-files script, but works on ICO files. It extracts the PNGs out of an ICO file, crushes them using optimize-png-files, and rebuilds the ICO. BUG=332639 Committed: https://crrev.com/580c7f1ad8a1d229b7309f99ae3a6a2fd07b3dcc Cr-Commit-Position: refs/heads/master@{#343854}

Patch Set 1 : #

Patch Set 2 : Cleanup. #

Patch Set 3 : Minor. #

Patch Set 4 : Remove TODO (too hard). #

Patch Set 5 : More fixes, and added warning for large uncompressed images. #

Total comments: 11

Patch Set 6 : Respond to comments. #

Patch Set 7 : Added instructions on crushing icons to chrome/app/theme/README. #

Patch Set 8 : README: Improve .ico production process. #

Patch Set 9 : 2-space indents and TitleCase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -0 lines) Patch
M chrome/app/theme/README View 1 2 3 4 5 6 7 1 chunk +38 lines, -0 lines 0 comments Download
A tools/resources/optimize-ico-files.py View 1 2 3 4 5 6 7 8 1 chunk +183 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
Matt Giuca
Oops, I uploaded this 19 months ago and forgot to mail it out ¯_(ツ)_/¯ Did ...
5 years, 4 months ago (2015-08-10 05:49:10 UTC) #2
oshima
https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py File tools/resources/optimize-ico-files.py (right): https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py#newcode32 tools/resources/optimize-ico-files.py:32: """Represents an invalid ICO file.""" 2 indent https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py#newcode34 tools/resources/optimize-ico-files.py:34: ...
5 years, 4 months ago (2015-08-18 01:41:26 UTC) #3
Matt Giuca
https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py File tools/resources/optimize-ico-files.py (right): https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py#newcode32 tools/resources/optimize-ico-files.py:32: """Represents an invalid ICO file.""" On 2015/08/18 01:41:26, oshima ...
5 years, 4 months ago (2015-08-18 04:43:45 UTC) #4
Matt Giuca
Added instructions to README on preparing icons.
5 years, 4 months ago (2015-08-18 04:50:42 UTC) #5
oshima
https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py File tools/resources/optimize-ico-files.py (right): https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py#newcode32 tools/resources/optimize-ico-files.py:32: """Represents an invalid ICO file.""" On 2015/08/18 04:43:45, Matt ...
5 years, 4 months ago (2015-08-18 06:36:35 UTC) #6
Matt Giuca
Note: The changes to the README file also. https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py File tools/resources/optimize-ico-files.py (right): https://codereview.chromium.org/130583003/diff/110001/tools/resources/optimize-ico-files.py#newcode32 tools/resources/optimize-ico-files.py:32: """Represents ...
5 years, 4 months ago (2015-08-18 07:26:22 UTC) #7
oshima
lgtm On 2015/08/18 07:26:22, Matt Giuca wrote: > Note: The changes to the README file ...
5 years, 4 months ago (2015-08-18 07:48:05 UTC) #8
Matt Giuca
On 2015/08/18 07:48:05, oshima wrote: > Oh, maybe that's really cros specific. If that's the ...
5 years, 4 months ago (2015-08-18 07:55:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/130583003/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/130583003/190001
5 years, 4 months ago (2015-08-18 07:55:48 UTC) #11
commit-bot: I haz the power
Committed patchset #9 (id:190001)
5 years, 4 months ago (2015-08-18 08:03:18 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 08:04:01 UTC) #13
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/580c7f1ad8a1d229b7309f99ae3a6a2fd07b3dcc
Cr-Commit-Position: refs/heads/master@{#343854}

Powered by Google App Engine
This is Rietveld 408576698