Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Side by Side Diff: build/android/strip_library_for_apk.py

Issue 13058003: Convert native strip from rule to action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@libraryloader
Patch Set: Fix package input paths Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/java_apk.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 import json
7 import optparse 8 import optparse
8 import os 9 import os
9 import sys 10 import sys
10 11
11 from pylib import build_utils 12 from pylib import build_utils
12 13
13 14
14 def StripLibrary(android_strip, android_strip_args, library_path, output_path): 15 def StripLibrary(android_strip, android_strip_args, library_path, output_path):
15 strip_cmd = ([android_strip] + 16 strip_cmd = ([android_strip] +
16 android_strip_args + 17 android_strip_args +
17 ['-o', output_path, library_path]) 18 ['-o', output_path, library_path])
18 build_utils.CheckCallDie(strip_cmd) 19 build_utils.CheckCallDie(strip_cmd)
19 20
20 21
21 def main(argv): 22 def main(argv):
22 parser = optparse.OptionParser() 23 parser = optparse.OptionParser()
23 24
24 parser.add_option('--android-strip', 25 parser.add_option('--android-strip',
25 help='Path to the toolchain\'s strip binary') 26 help='Path to the toolchain\'s strip binary')
26 parser.add_option('--android-strip-arg', action='append', 27 parser.add_option('--android-strip-arg', action='append',
27 help='Argument to be passed to strip') 28 help='Argument to be passed to strip')
29 parser.add_option('--libraries-dir',
30 help='Directory for un-stripped libraries')
28 parser.add_option('--stripped-libraries-dir', 31 parser.add_option('--stripped-libraries-dir',
29 help='Directory for stripped libraries') 32 help='Directory for stripped libraries')
33 parser.add_option('--libraries-file',
34 help='Path to json file containing list of libraries')
35 parser.add_option('--stamp', help='Path to touch on success')
30 36
31 options, paths = parser.parse_args() 37
38 options, _ = parser.parse_args()
39
40 with open(options.libraries_file, 'r') as libfile:
41 libraries = json.load(libfile)
32 42
33 build_utils.MakeDirectory(options.stripped_libraries_dir) 43 build_utils.MakeDirectory(options.stripped_libraries_dir)
34 44
35 for library_path in paths: 45 for library in libraries:
36 stripped_library_path = os.path.join(options.stripped_libraries_dir, 46 library_path = os.path.join(options.libraries_dir, library)
37 os.path.basename(library_path)) 47 stripped_library_path = os.path.join(
48 options.stripped_libraries_dir, library)
38 StripLibrary(options.android_strip, options.android_strip_arg, library_path, 49 StripLibrary(options.android_strip, options.android_strip_arg, library_path,
39 stripped_library_path) 50 stripped_library_path)
40 51
52 if options.stamp:
53 build_utils.Touch(options.stamp)
54
41 55
42 if __name__ == '__main__': 56 if __name__ == '__main__':
43 sys.exit(main(sys.argv)) 57 sys.exit(main(sys.argv))
OLDNEW
« no previous file with comments | « no previous file | build/java_apk.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698