Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1305793002: Update overlay cast buttons for clank, part 1 of 3. (Closed)

Created:
5 years, 4 months ago by liberato (no reviews please)
Modified:
5 years, 3 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, rwlbuis, nessy, vcarbune.chromium, jennschen, aberent
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make overlay cast buttons for clank partially transparent, part 1 of 3. The updated design spec for the 'overlay cast off' asset is partially transparent. This CL incorporates that asset, and moves to the new position of 8px from the upper left. Also adds an 'overlay cast on' asset, which has been missing for quite some time. It is unreferenced, but is needed so that it can be added to blink_resources_constants.h in a separate CL. We can then start using it in blink in a third CL. BUG=522580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201527

Patch Set 1 #

Patch Set 2 : position to 8px from 16. #

Patch Set 3 : replaced blank line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M Source/core/css/mediaControlsNew.css View 1 1 chunk +2 lines, -2 lines 0 comments Download
M public/blink_image_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M public/default_100_percent/blink/mediaplayer_overlay_cast_off_new.png View Binary file 0 comments Download
A public/default_100_percent/blink/mediaplayer_overlay_cast_on_new.png View Binary file 0 comments Download

Messages

Total messages: 22 (8 generated)
liberato (no reviews please)
5 years, 4 months ago (2015-08-21 18:55:50 UTC) #2
pdr.
On 2015/08/21 at 18:55:50, liberato wrote: > This looks good to me but I'm probably ...
5 years, 4 months ago (2015-08-21 19:33:33 UTC) #3
pdr.
5 years, 4 months ago (2015-08-21 19:33:45 UTC) #5
whywhat
+Jenn and Aberent for a heads up
5 years, 4 months ago (2015-08-21 19:38:37 UTC) #7
Elliot Glaysher
On 2015/08/21 19:33:33, pdr wrote: > This looks good to me but I'm probably not ...
5 years, 4 months ago (2015-08-21 19:43:52 UTC) #8
liberato (no reviews please)
On 2015/08/21 19:33:33, pdr wrote: > On 2015/08/21 at 18:55:50, liberato wrote: > > > ...
5 years, 4 months ago (2015-08-21 19:51:12 UTC) #9
philipj_slow
LGTM, but it's worrying that there are no test failures. It's a good thing that ...
5 years, 4 months ago (2015-08-24 09:47:12 UTC) #10
liberato (no reviews please)
On 2015/08/24 09:47:12, philipj wrote: > LGTM, but it's worrying that there are no test ...
5 years, 4 months ago (2015-08-24 14:19:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305793002/40001
5 years, 4 months ago (2015-08-24 14:19:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103073)
5 years, 4 months ago (2015-08-24 15:04:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305793002/40001
5 years, 4 months ago (2015-08-25 21:23:35 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/104196)
5 years, 4 months ago (2015-08-25 22:49:31 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305793002/40001
5 years, 3 months ago (2015-09-01 05:53:19 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 07:22:26 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201527

Powered by Google App Engine
This is Rietveld 408576698