Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1305763002: Revert of Moving ArraySplice Builtin to ElementsAccessor (Closed)

Created:
5 years, 4 months ago by Camillo Bruni
Modified:
5 years, 4 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Moving ArraySplice Builtin to ElementsAccessor (patchset #6 id:100001 of https://codereview.chromium.org/1293683005/ ) Reason for revert: failing bot http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/3827 Original issue's description: > - remove the Backing-Store speficic code from builtins.cc and put it in elements.cc. > - adding tests to improve coverage of the splice method > > BUG= > > Committed: https://crrev.com/8533d4b5433d3a9e9fb1015f206997bd6d869fe3 > Cr-Commit-Position: refs/heads/master@{#30269} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6d67f7db3797620e1daf4e52f57782f70d4a4d2f Cr-Commit-Position: refs/heads/master@{#30271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -295 lines) Patch
M src/builtins.cc View 3 chunks +182 lines, -44 lines 0 comments Download
M src/elements.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/elements.cc View 7 chunks +19 lines, -193 lines 0 comments Download
M test/mjsunit/array-natives-elements.js View 7 chunks +12 lines, -33 lines 0 comments Download
M test/mjsunit/array-splice.js View 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Camillo Bruni
Created Revert of Moving ArraySplice Builtin to ElementsAccessor
5 years, 4 months ago (2015-08-20 13:50:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305763002/1
5 years, 4 months ago (2015-08-20 13:50:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 13:51:04 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d67f7db3797620e1daf4e52f57782f70d4a4d2f Cr-Commit-Position: refs/heads/master@{#30271}
5 years, 4 months ago (2015-08-20 13:51:25 UTC) #4
mvstanton
5 years, 4 months ago (2015-08-20 14:12:50 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698